Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update text for unknown operations in proposals #3663

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

abitmore
Copy link
Member

@abitmore abitmore commented Sep 3, 2023

General

PR for #3661.

Show the text "Unknown operation" with the operation type number for operations which are not yet implemented in UI. For those operations, link to the internal block explorer is removed because it is either broken (on the proposal details page) or redundant (on the account activities page).

Translation was done with Google Translate.

See https://pr.bts.mobi/#/account/blockchain-prize for result of changes.

This is the first step in fixing issues like #3661. Since it is a catch-all solution, it could reduce similar scam issues in the future. I think it's urgent and we need to release a new version containing it ASAP. To be clear, I know we want to support showing all operation types in proposals, and we can do it step by step.

General

Please make sure the following is done:

Code Preparation

Please review all your changes one last time before committing

  • Check for unused code
  • No unrelated changes are included
  • None of the changed files are reformatting only
  • Code is self explanatory or documented
  • All written text is properly translated (english language)

Testing

The branch has been tested on the following browsers (desktop and mobile view)

  • Chrome
  • Opera
  • Firefox
  • Safari

Please provide screenshots/licecap of your changes below
image
image

In German:
image

@sschiessl-bcp
Copy link
Contributor

For reference, this is how it looks before
image

@sschiessl-bcp sschiessl-bcp merged commit 276ad8b into develop Sep 4, 2023
@sschiessl-bcp sschiessl-bcp deleted the update-operation-details branch September 4, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants